London | 26-ITP-May | Yonatan Teklemariam | Sprint 3 | Implement and re-write tests#1381
Open
Yonatanteklemariam wants to merge 7 commits into
Open
London | 26-ITP-May | Yonatan Teklemariam | Sprint 3 | Implement and re-write tests#1381Yonatanteklemariam wants to merge 7 commits into
Yonatanteklemariam wants to merge 7 commits into
Conversation
Yonatanteklemariam
added
Complete
Yonatanteklemariam
added
the
Needs Review
cjyuan
reviewed
Jun 27, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Code looks good.
Can you revert the changes made in the 2-practice-tdd folder? I think they belong to a separate PR.
cjyuan
added
Reviewed
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Author
|
Remove check for zero numerator in isProperFraction function.
Yonatanteklemariam
added
Needs Review
cjyuan
reviewed
Jun 28, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Have you rerun the test scripts after you made changes? It's a good practice to run the test scripts before making a commit or pushing the commits to GitHub.
Comment on lines
+17
to
+19
| if (Number.isNaN(numerator) || Number.isNaN(denominator)) { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
Note: A stronger check might be !Number.isFinite() (or !Number.isInteger() if you only allow integer numerator and denominator).
No change needed.
cjyuan
added
Reviewed
Yonatanteklemariam
added
Needs Review
Contributor
|
I don't see any new commits on this branch. Have you made any change to address this comment: #1381 (review) ? |
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Defined a new function based on the instruction and wrote tests to verify the output matches the expected target output.
Questions